Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tensorflow Prebuilt containers and saving method #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Matt-Viner
Copy link

Description

This repository has outdated versions of the GCP pre-built containers for training and serving Tensorflow models (2.6 is no longer being patched and will be removed from GCP in September 2024), so I have updated them to use version 2.12, this also requires a saving approach to change, as models saved with tf_model.save() method are not picked up by the pre-built prediction container. This has been updated to tf.saved_model.save() which should work ok.

How has this been tested?

I have made this change in an Org Repo that uses this template for training and serving tensorflow models, which ran successfully E2e. I don't personally have access to GCP or Vertex AI unfortunately!

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have successfully run the E2E tests, and have included the links to the pipeline runs below
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated any relevant documentation to reflect my changes
  • I have assigned a reviewer and messaged them

Pipeline run links:

Copy link

google-cla bot commented Feb 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant