-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace debian_package_manager with apt #1542
Conversation
a13c3d0
to
a5c5e1d
Compare
🌳 🔄 Image Check |
run: | | ||
for i in $(seq 5); do | ||
bazel --bazelrc=$GITHUB_WORKSPACE/.github/workflows/ci.bazelrc fetch //private/pkg/test/oci_image:test_sboms && break || sleep 20; | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto format :(
@@ -217,16 +223,15 @@ Distroless tracks the upstream Debian releases, using [Github actions to automat | |||
|
|||
### Debug Images | |||
|
|||
Distroless images are minimal and lack shell access. The ```:debug``` image set for each language provides a busybox shell to enter. | |||
Distroless images are minimal and lack shell access. The `:debug` image set for each language provides a busybox shell to enter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loosebazooka we should probably run pre-commit on the whole repo and rebase here. Can you do that?
@@ -0,0 +1,166 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would prefer these be separate scripts that had more descriptive names rather than knife?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming is tbd, i can split them as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can make that knife change in a followup?
Yes, i'll remove it from here. |
Oh, actually we can't as there's no replacement for what debian_package_manger did to upgrade snapshots etc. now those logic lives in this shell script. If i remove it from here, the CI will fail at midnight. |
This the effort for replacing debian package manager with GoogleContainerTools/rules_distroless#16
And a follow up to #1541