Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace debian_package_manager with apt #1542

Merged
merged 8 commits into from
Apr 2, 2024
Merged

feat: replace debian_package_manager with apt #1542

merged 8 commits into from
Apr 2, 2024

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented Mar 9, 2024

This the effort for replacing debian package manager with GoogleContainerTools/rules_distroless#16

And a follow up to #1541

@thesayyn thesayyn marked this pull request as draft March 9, 2024 19:55
@thesayyn thesayyn force-pushed the use_apt branch 4 times, most recently from a13c3d0 to a5c5e1d Compare March 10, 2024 00:30
Copy link
Contributor

github-actions bot commented Mar 10, 2024

🌳 🔄 Image Check
This pull request doesn't make any changes to the images. 👍
You can check the details in the report here

run: |
for i in $(seq 5); do
bazel --bazelrc=$GITHUB_WORKSPACE/.github/workflows/ci.bazelrc fetch //private/pkg/test/oci_image:test_sboms && break || sleep 20;
done
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto format :(

@@ -217,16 +223,15 @@ Distroless tracks the upstream Debian releases, using [Github actions to automat

### Debug Images

Distroless images are minimal and lack shell access. The ```:debug``` image set for each language provides a busybox shell to enter.
Distroless images are minimal and lack shell access. The `:debug` image set for each language provides a busybox shell to enter.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loosebazooka we should probably run pre-commit on the whole repo and rebase here. Can you do that?

@@ -0,0 +1,166 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer these be separate scripts that had more descriptive names rather than knife?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming is tbd, i can split them as well.

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can make that knife change in a followup?

@thesayyn
Copy link
Collaborator Author

thesayyn commented Apr 2, 2024

LGTM, we can make that knife change in a followup?

Yes, i'll remove it from here.

@thesayyn
Copy link
Collaborator Author

thesayyn commented Apr 2, 2024

Oh, actually we can't as there's no replacement for what debian_package_manger did to upgrade snapshots etc. now those logic lives in this shell script. If i remove it from here, the CI will fail at midnight.

@loosebazooka loosebazooka self-requested a review April 2, 2024 16:29
@loosebazooka loosebazooka merged commit 3ab2fbe into main Apr 2, 2024
10 checks passed
@loosebazooka loosebazooka deleted the use_apt branch April 2, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants