Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buildifier #108

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: buildifier #108

merged 1 commit into from
Oct 28, 2024

Conversation

jjmaestro
Copy link
Contributor

Run buildifier -r . to fix failed checks from previous PRs.

@jjmaestro
fix: buildifier
2902c2c 
Run `buildifier -r .` to fix failed checks from previous PRs.
@jjmaestro
Copy link
Contributor Author

jjmaestro commented Oct 28, 2024 •
edited
Loading

I think #102 and #5? introduced Buildifier failures that are now failing checks, probably best to fix it so that the checks are all green in the PRs.

@thesayyn let me know if you can accept this one quickly so I'll rebase all of my outstanding PRs over this!

@jjmaestro jjmaestro mentioned this pull request Oct 28, 2024
Merged
@thesayyn
Copy link
Collaborator

Sorry, i prematurely landed those PRs. thanks for fixing it.

@thesayyn thesayyn merged commit 30c3960 into GoogleContainerTools:main Oct 28, 2024
10 checks passed
@jjmaestro jjmaestro deleted the fix-buildifier-failed-check branch October 28, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjmaestro @thesayyn