-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more convenience targets #121
base: main
Are you sure you want to change the base?
feat: add more convenience targets #121
Conversation
776d3ca
to
5c38a79
Compare
@thesayyn sorry for the noise :( I'll back out the rebase and pull the last fix that changes the architecture map into a separate PR. |
@thesayyn the noise comes from the stacked PRs, when I rebased this PR on top of #120, I didn't realize it would make it much harder to review 😞 I'm used to stacked PRs and rebases "just working" and GH is pretty terrible when it comes to this, I didn't realize it would dump all of the contents from your PR in here as changes :-/ Can you review #120 first? That PR is all straight-forward fixes, I hope it's easier to review. Otherwise, you can focus on just this two commits:: |
5c38a79
to
f164387
Compare
OK, I managed to back out the rebase, this PR is now "clean" and separate from #120. I'm really really sorry for all the noise, I'm still getting used to working with GH's limitations :( |
affa9ec
to
4a05c89
Compare
@thesayyn I've further simplified the PR removing all of the "refactored" methods, so now it's just clear that the PR ditched the Let me know if the PR is to your liking, I'll be happy to make more changes if needed. Thanks. |
4a05c89
to
3327243
Compare
99e0b8f
to
b198392
Compare
@thesayyn I'm going to rebase the branch on Learning to work around GH limitations... 😅 |
Mirror the "inner" (per-arch) :data and :control convenience targets to platform-aware targets at the top of the package repo so that we can use `@<REPO>//<PACKAGE>:data` directly (see changes to examples/debian_snapshot/BUILD).
With the changes in GoogleContainerTools#115 and the previous commit, we can now remove a bunch of select from the examples and use the new target aliases.
b198392
to
860dd9c
Compare
@thesayyn and, again, after I did the two pushes before the rebase, somehow GH is not showing the "Compare" for the two of them, only for the last one (the This makes it impossible to see the changes I did to address your comments... this is absurd, I really don't know how GH can be failing at this stuff o.0. Here's my "manual compare link" between the changes: |
Add platform-aware
:data
and:control
convenience targets at the top of the package repo so that we can use@<REPO>//<PACKAGE>:data
directly. See changes toexamples/debian_snapshot/BUILD
:Also, add
:deps
to complement:data
.Finally, with the changes in #115 and the previous commit, we can now remove a bunch of select from the examples and use the new target aliases.
NOTE: This PR adds to #115 some functionality that I had in #100 and we can close #100 completely.