Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove latest tagging from release process v2.3 #8987

Merged
merged 2 commits into from
Aug 4, 2023
Merged

chore: remove latest tagging from release process v2.3 #8987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f2adf3
chore: remove latest tagging from relase process
ericzzzzzzz Aug 3, 2023
20897b0
chore: configure minikube to a static version in github ci (#8951)
ericzzzzzzz Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/integration-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
ko_version: [0.4.0]
kompose_version: [1.21.0]
kpt_version: [1.0.0-beta.24]
minikube_version: [1.30.1]
gcloud_sdk_version: [410.0.0]
container_structure_tests_version: [1.8.0]
integration_test_partitions: [0, 1, 2, 3]
Expand Down Expand Up @@ -111,10 +112,10 @@ jobs:
echo '{}' > ${HOME}/.docker/config.json
mkdir -p ${HOME}/.m2/ && cp ./hack/maven/settings.xml ${HOME}/.m2/settings.xml

- name: Install Minikube from minikube master branch @HEAD and start cluster
- name: Install Minikube and start cluster
if: ${{ env.NON_DOCS_FILES_CHANGED != 0 }}
run: |
curl -Lo minikube https://storage.googleapis.com/minikube-builds/master/minikube-linux-amd64
curl -Lo minikube https://github.com/kubernetes/minikube/releases/download/v${{ matrix.minikube_version }}/minikube-linux-amd64
sudo install minikube /usr/local/bin/minikube
minikube start --profile=minikube --driver=docker

Expand Down
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ release: $(BUILD_DIR)/VERSION
--build-arg VERSION=$(VERSION) \
-f deploy/skaffold/Dockerfile \
--target release \
-t gcr.io/$(GCP_PROJECT)/skaffold:latest \
-t gcr.io/$(GCP_PROJECT)/skaffold:$(VERSION) \
.

Expand Down
1 change: 0 additions & 1 deletion deploy/cloudbuild-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ steps:
- 'version'

images:
- 'gcr.io/$PROJECT_ID/skaffold:latest'
- 'gcr.io/$PROJECT_ID/skaffold:$TAG_NAME'

options:
Expand Down