Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle to store JSON files scanItems.json and scanData.json #424

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Toggle to store JSON files scanItems.json and scanData.json #424

merged 4 commits into from
Dec 23, 2024

Conversation

WilsonkwSheng
Copy link
Collaborator

@WilsonkwSheng WilsonkwSheng commented Dec 18, 2024 •
edited by younglim
Loading

This PR adds...
-g yes to store raw scanItems.json and scanData.json

  • I've kept this PR as small as possible (~500 lines) by splitting it into PRs with manageable chunks of code
  • I've requested reviews from 1 reviewer
  • I've tested existing features (website scan, sitemap, custom flow) in both node index and cli
  • I've synced this fork with GovTechSG repo
  • I've added/updated unit tests
  • I've added/updated any necessary dependencies in package[-lock].json npm audit, portable installation on GitHub Actions

@younglim younglim self-requested a review December 23, 2024 06:49
@younglim younglim changed the title Generate JSON files for scanItems and scanData Toggle to store JSON files scanItems.json and scanData.json Dec 23, 2024
@younglim
Copy link
Collaborator

younglim commented Dec 23, 2024 •
edited
Loading

npm run cli -- ... -g yes

image

@younglim younglim merged commit 5883f80 into master Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younglim younglim Awaiting requested review from younglim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilsonkwSheng @younglim