fix(masthead): remove trusted website title tag

GovTechSG · Oct 23, 2023 · 8537a91 · 8537a91
1 parent 4f53b0b
commit 8537a91
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/scripts/frankBuild.js b/scripts/frankBuild.js
@@ -43,14 +43,14 @@ async function includeFileInBuild(file, targetFolder = distPath) {
  *  <script type="module" src="https://cdn.jsdelivr.net/npm/@govtechsg/sgds-web-component/Masthead/index.js">
  */
 async function copyMastheadCdnToRoot() {
-  await mkdir("./lib/Masthead")
-  await copy("./lib/components/Masthead/index.umd.js", "./lib/Masthead/index.js")
+  await mkdir("./lib/Masthead");
+  await copy("./lib/components/Masthead/index.umd.js", "./lib/Masthead/index.js");
 }
 async function run() {
   try {
     await createPackageFile();
     await includeFileInBuild("./README.md");
-    await copyMastheadCdnToRoot()
+    await copyMastheadCdnToRoot();
     // await includeFileInBuild('../../LICENSE');
   } catch (err) {
     console.error(err);

diff --git a/src/components/Masthead/sgds-masthead.ts b/src/components/Masthead/sgds-masthead.ts
@@ -135,7 +135,6 @@ export class SgdsMasthead extends SgdsElement {
                           viewBox="0 0 32 32"
                           class="trusted-websites-icon"
                         >
-                          <title>Trusted websites</title>
                           <path
                             d="M18.667 4v2.667h4c0.186-0.020 0.374-0.020 0.56 0l-2.667 2.667-6.973 6.987 1.88 1.88 9.733-9.667c0.092 0.257 0.137 0.528 0.133 0.8v4h2.667v-9.333h-9.333z"
                           ></path>

diff --git a/test/masthead.test.ts b/test/masthead.test.ts
@@ -15,7 +15,6 @@ describe("sgds-masthead", () => {
             <div class="col">
               <div class="masthead-layout">
                 <svg version="1.1" xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 32 32" class="sg-crest">
-                  <title>sg-crest</title>
                   <path d="M5.896 11.185c0 0-0.949 1.341 0.294 3.075 0 0 0.196-0.883 2.159-0.883h2.356c2.225 0 3.893-2.126 2.846-4.319 0 0 1.57 0.164 2.095-0.818 0.523-0.981-0.033-1.374-0.818-1.374h-3.959c0 0.704-1.341 0.802-1.341 0h-2.225c0 0-1.669 0-1.701 1.407 0 0 0.377-0.229 0.752-0.261v0.375c0 0-0.458 0.082-0.671 0.197-0.212 0.114-0.523 0.425-0.228 1.227 0.294 0.801 0.409 1.079 0.409 1.079s0.475-0.41 1.244-0.41h0.9c1.602 0 1.308 1.554-0.295 1.554s-1.815-0.85-1.815-0.85z"></path>
                   <path d="M14.255 9.566c0 0 0.54 0.033 0.932-0.31 0 0 3.55 2.765-1.717 8.326-5.268 5.562-1.195 9.162-1.195 9.162s-0.948 0.915-0.409 2.699c0 0-2.191-1.237-3.867-3.338-2.422-3.036-3.902-7.681 2.749-11.386 0 0 4.389-2.208 3.506-5.153z"></path>
                   <path d="M8.829 6.343c0 0 0.709-1.265 2.355-1.265 1.298 0 1.594-0.666 1.594-0.666s0.566-1.079 3.424-1.079c2.619 0 4.384 0.873 5.812 2.039 0 0-3.85-2.388-7.645 0.971h-5.54z"></path>
@@ -51,7 +50,6 @@ describe("sgds-masthead", () => {
                     <article>
                       Government agencies communicate via .gov.sg websites (e.g. go.gov.sg/open).
                       <a href="https://www.gov.sg/trusted-sites#govsites" class="trusted-websites-link" rel="noreferrer" target="_blank">Trusted websites<svg version="1.1" xmlns="http://www.w3.org/2000/svg" width="18" height="18" viewBox="0 0 32 32" class="trusted-websites-icon">
-                          <title>Trusted websites</title>
                           <path d="M18.667 4v2.667h4c0.186-0.020 0.374-0.020 0.56 0l-2.667 2.667-6.973 6.987 1.88 1.88 9.733-9.667c0.092 0.257 0.137 0.528 0.133 0.8v4h2.667v-9.333h-9.333z"></path>
                           <path d="M22.667 25.333h-16v-16h8v-2.667h-8c-1.473 0-2.667 1.194-2.667 2.667v16c0 1.473 1.194 2.667 2.667 2.667h16c1.473 0 2.667-1.194 2.667-2.667v-8h-2.667v8z"></path></svg></a>
                     </article>