Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][HH] correct proxy agent initialization as it now uses proxy-from-env #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hermawan-hadi
Copy link
Contributor

correct proxy agent initialization

@Gyunikuchan
Copy link
Collaborator

Gyunikuchan commented Dec 6, 2023

  1. May I check if the reading proxy of env vars was tested?
  2. If so, may I also get your help to clean it up by removing the const proxyConfig = getProxyConfig();, the associated code and comments?

@hermawan-hadi
Copy link
Contributor Author

i tested it when i raised this in jul.

to clarify, our team do not use this feature and i only update the constructor as its signature changed in the new major version. i update it from the old version as there was a 9.8/10 vuln tied it. the constructor still can takes the args but the recommended way is through env var which is how its originally set.

the const proxyConfig = getProxyConfig(); is still used as proxyConfig decides if proxyagent will be created and attached it to the axios instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants