Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

fix: replace logout dialog with a toast (#758) #816

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: replace logout dialog with a toast (#758) #816

merged 1 commit into from
Sep 4, 2023

Conversation

0xMRTT
Copy link
Member

@0xMRTT 0xMRTT commented Sep 4, 2023

Description

Replace logout message with toast HIG

Fixes #758

Type of change

  • Bugfix (Change which fixes an issue)
  • New feature (Change which adds new functionality)
  • Enhancement (Change which slightly improves existing code)
  • Breaking change (This change will introduce incompatibility with existing functionality)

Testing

  • I have tested my changes and verified that they work as expected

@0xMRTT 0xMRTT requested a review from daudix September 4, 2023 20:45
@daudix
Copy link
Member

daudix commented Sep 4, 2023

Can't test rn but looking at diff, LGTM

@0xMRTT
Copy link
Member Author

0xMRTT commented Sep 4, 2023

When you will try this merge it!

@daudix
Copy link
Member

daudix commented Sep 4, 2023

Uh oh I guess it won't happen soon, so it's the merge time!

@daudix daudix merged commit 5cdcfc9 into main Sep 4, 2023
@daudix daudix deleted the update-logout branch September 4, 2023 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daudix daudix daudix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

track: Some (small) changes before 0.8
2 participants
@0xMRTT @daudix