-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ud2gf: Fallback to morphoanalyze if parse fails + use Str functions for lexical backups #30
Draft
anka-213
wants to merge
14
commits into
GrammaticalFramework:master
Choose a base branch
from
anka-213:morphoanalyze-fallback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ud2gf: Fallback to morphoanalyze if parse fails + use Str functions for lexical backups #30
anka-213
wants to merge
14
commits into
GrammaticalFramework:master
from
anka-213:morphoanalyze-fallback
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anka-213
force-pushed
the
morphoanalyze-fallback
branch
3 times, most recently
from
March 30, 2022 09:14
3057fee
to
517d322
Compare
anka-213
force-pushed
the
morphoanalyze-fallback
branch
from
April 26, 2022 05:36
517d322
to
17a4ed8
Compare
This reduces the problem with showCId escaping everything
This prevents a Prelude.head error form occurring
anka-213
force-pushed
the
morphoanalyze-fallback
branch
from
May 4, 2022 05:42
17a4ed8
to
d94a5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat breaking change if someone relied of the old way of inventing functions, but on the other hand, it didn't produce valid GF expressions in those cases, so it's unlikely that anything would break in practice.
One option is to put this behaviour behind a flag, so the new behaviour is opt-in, as is suggested in #24?