Cleaning up clustering code for v1.2 branch #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquil11
commented
Apr 12, 2024
| GRB_TRY(GrB_reduce(w, NULL, NULL, GrB_PLUS_MONOID_FP32, T_temp, | ||
| GrB_DESC_T0)); | ||
| GRB_TRY(GrB_apply(w, NULL, NULL, GrB_MINV_FP32, w, NULL)); | ||
| if (D != NULL) GrB_free(&D); |
There was a problem hiding this comment.
Not sure if this is necessary, I was getting memory leaks if this check was not done though
cquil11
commented
Apr 12, 2024
|
|
||
| // Set T to the previous iteration | ||
| if (T != NULL) GrB_free(&T); |
There was a problem hiding this comment.
not entirely sure if a deep copy is needed here
cquil11
commented
Apr 12, 2024
| n = nrows; | ||
|
|
||
| // All types of input matrices get cast to type FP32 for this algorithm | ||
| GRB_TRY(GrB_Matrix_new(&A, GrB_FP32, n, n)); | ||
| GRB_TRY(GrB_apply(A, NULL, NULL, GrB_IDENTITY_FP32, G->A, NULL)); |
cquil11
commented
Apr 12, 2024
| LG_FREE_WORK; \ | ||
| #define LG_FREE_ALL \ | ||
| { \ | ||
| LG_FREE_WORK; \ |
There was a problem hiding this comment.
not freeing the double pointer handles, not sure if I need to or if that's just for GB objects
cquil11
commented
Apr 12, 2024
|
|
||
| m = out_degree_sum; | ||
| double norm = 1.0 / (m * m); | ||
|
|
||
| // Compute modularity | ||
| // compute modularity |
There was a problem hiding this comment.
Need input on if there needs to be a distinction between undirected and directed. I feel like there should be, however I get consistent results with this code.
cquil11
commented
Apr 12, 2024
|
|
||
| // Now we need to find *which* cluster(s) cast the highest votes, for this we need argmax code | ||
| // taken from T. Davis SS User Guide p. 286 | ||
| if (D != NULL) |
There was a problem hiding this comment.
this again, to avoid memory leaks. needed??
|
I still need to add the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.