CF toolkit: Use rankUpdate() to calculate XtX in ALS and WALS #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes, first is a typo fix, libFM writes the item_bias factor with the file extension ".mm" but tries to read it with extension ".m".
The second change is to use rankUpdate when computing XtX in the ALS and weighted ALS implementation. The function rankUpdate() provides an optimized way to compute M += alpha(uu*), which is exactly what we want.
In some simple testing on the small Netflix data I was seeing runtimes cut in half with this change.