Pull request for recommender system framework over GraphChi for review #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param rec: The recommender to be added to the recommender pool. | ||
| */ | ||
| public void addNewRecommender(RecommenderAlgorithm rec) { | ||
| //Add the new recommeder to pending list |
There was a problem hiding this comment.
This is not thread-safe, but I am not sure if it has to be.
…rformance and bugs.
Conflicts: src/main/java/edu/cmu/graphchi/toolkits/collaborative_filtering/utils/SerializationUtils.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all the files in "toolkits/collaborative_filtering" package are new files added by me.
In the existing code, I have made some changes to FastSharder.java (some of the changes about metadata can be deleted)
The python files submitted under "scripts" was for some specific data processing. I am not sure if the correct place for them is to live in this repository right now.
Some more details about the code is in this google document as well:
https://docs.google.com/document/d/1w7zlZyG8jXnriqUokYVldr6MYTo9fRm4Q0EwF2TyVrY