Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Network permission from calling app opening a URL #405

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quh4gko8
Copy link
Member

Resolve #37, and requires https://github.com/GrapheneOS/platform_frameworks_base/pull/446 to function.

This PR also improves search activity behavior by acting like opened from incognito tab to avoid fetching for suggestions whenever "open external links in incognito" is enabled.

@quh4gko8 quh4gko8 requested a review from thestinger November 17, 2023 09:48
@quh4gko8 quh4gko8 force-pushed the various-improvements branch from 9c2b859 to 508b92f Compare November 17, 2023 11:19
@quh4gko8 quh4gko8 changed the title Match incognito tab behavior for search activity when "open links in incognito" is enabled + Enforce Network permission from calling app Enforce Network permission from calling app Nov 17, 2023
@quh4gko8 quh4gko8 changed the title Enforce Network permission from calling app Enforce Network permission from calling app opening a URL Nov 17, 2023
@quh4gko8 quh4gko8 force-pushed the various-improvements branch from 508b92f to c4a0d8f Compare November 17, 2023 11:21
@quh4gko8 quh4gko8 marked this pull request as draft November 19, 2023 18:07
@quh4gko8 quh4gko8 marked this pull request as ready for review November 28, 2023 16:58
@quh4gko8 quh4gko8 marked this pull request as draft November 28, 2023 16:58
@thestinger thestinger force-pushed the main branch 3 times, most recently from 579e3d3 to 4caf62a Compare February 18, 2024 19:56
@quh4gko8 quh4gko8 force-pushed the various-improvements branch 4 times, most recently from 70a1e5b to ce8d900 Compare May 9, 2024 17:56
@quh4gko8 quh4gko8 marked this pull request as ready for review May 9, 2024 19:25
@quh4gko8 quh4gko8 force-pushed the various-improvements branch from ce8d900 to 67becc9 Compare May 10, 2024 15:44
@quh4gko8 quh4gko8 marked this pull request as draft May 17, 2024 09:32
@thestinger thestinger force-pushed the main branch 3 times, most recently from 8b72e2f to 2ffe602 Compare May 22, 2024 20:36
@quh4gko8 quh4gko8 force-pushed the various-improvements branch from 67becc9 to fcd0a24 Compare June 21, 2024 23:57
@quh4gko8 quh4gko8 force-pushed the various-improvements branch from fcd0a24 to 9649801 Compare June 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant