Depreciate STORAGE permission #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndsxx6swthntex
changed the title
thestinger
reviewed
Oct 7, 2020
| @@ -200,6 +200,7 @@ by a child template that "extends" this file. | ||
| android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize|uiMode|density"> | ||
| </activity> | ||
| <activity-alias android:name="com.google.android.apps.chrome.IntentDispatcher" |
There was a problem hiding this comment.
This will end up rejecting requests from apps without the permission. We need to do it in a way that users are prompted about it.
|
BTW, |
|
I merged the storage permission change. I can't take the other change. |
|
Unfortunately, ended up having to revert this due to #90. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are being downloaded and viewed on Download directory even if the permission is gone. Further investigations are being done as of the moment. Also, an initial attempt to gate IntentDispatcher by INTERNET permission has been done.