linux: make use of mseal(2) #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestinger
reviewed
Jul 24, 2024
memory.c
Outdated
| return false; | ||
| if (unlikely(errno == ENOMEM)) | ||
| return true; | ||
| if (likely(errno == ENOSYS)) |
There was a problem hiding this comment.
This shouldn't be marked likely.
There was a problem hiding this comment.
Dropped.
Also marked the function COLD, since it is only called from init_slow_path() also tagged COLD.
There was a problem hiding this comment.
mseal(2) can return -EPERM on 32-bit architectures, should this be checked explicitly or is 32-bit not supported at all?
Instead of protecting the global read-only data structure after startup via the read-only flag, which can be reverted, use the in Linux 6.10 introduced irreversible syscall mseal(2).
|
I've been running this for about a week now without issue. |
|
Will get to this eventually, it's just very low priority due to low impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of protecting the global read-only data structure after startup via the read-only flag, which can be reverted, use the in Linux 6.10 introduced irreversible syscall mseal(2).