-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a profiling action to CI which comments on PRs with notable demo art performance variances #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Benchmark Results
|
Performance Benchmark Results
|
TrueDoctor
force-pushed
the
profile-ci
branch
2 times, most recently
from
August 14, 2024 10:12
1441a81
to
c6440d8
Compare
Performance Benchmark Results
|
TrueDoctor
force-pushed
the
profile-ci
branch
2 times, most recently
from
August 14, 2024 10:26
4b72cd8
to
7683ca9
Compare
Performance Benchmark Results
|
We unfortunetly can't fully test this yet as the ci tries to compare against master, but master does not have the necessary benchmark setup yet. And the ci only shows significant changes so we'll need to actually have changes to test against |
TrueDoctor
force-pushed
the
profile-ci
branch
2 times, most recently
from
August 15, 2024 10:39
7ae3918
to
49b0330
Compare
Keavon
changed the title
Add profile run to ci
Add a profiling action to CI which comments on PRs with notable demo art performance variances
Aug 15, 2024
Keavon
approved these changes
Aug 15, 2024
TrueDoctor
added a commit
that referenced
this pull request
Aug 15, 2024
…art performance variances (#1925) * Add profile run to ci * Remove cargo add * Rename more main to master * Don't run on master before the pr has been merged * Fix pr comment step * Fix comment v2 * Fix v3 * Fix missing features * Fix string interpolation * Only post comment on performance diff * Fix benchmark runner * Try adding escaping * Remove escaped quotes * Use proper master baseline * Use proper master baseline * Fix rebase regression * Remove unused dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.