Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a profiling action to CI which comments on PRs with notable demo art performance variances #1925

Merged
merged 17 commits into from
Aug 15, 2024

Conversation

TrueDoctor
Copy link
Member

No description provided.

Copy link

Performance Benchmark Results


Copy link

Performance Benchmark Results

"
"

@TrueDoctor TrueDoctor force-pushed the profile-ci branch 2 times, most recently from 1441a81 to c6440d8 Compare August 14, 2024 10:12
Copy link

Performance Benchmark Results

"
"

@TrueDoctor TrueDoctor force-pushed the profile-ci branch 2 times, most recently from 4b72cd8 to 7683ca9 Compare August 14, 2024 10:26
Copy link

Performance Benchmark Results

"�[32mcompile_demo_art::compile_group::iai_compile_to_proto�[0m
  Baselines:                       |master
  Instructions:     �[1m      604849972�[0m|604981171       (�[1;92m-0.02169%�[0m) [�[1;92m-1.00022x�[0m]
  L1 Hits:          �[1m      859450007�[0m|859602701       (�[1;92m-0.01776%�[0m) [�[1;92m-1.00018x�[0m]
  L2 Hits:          �[1m        4403628�[0m|4412988         (�[1;92m-0.21210%�[0m) [�[1;92m-1.00213x�[0m]
  RAM Hits:         �[1m        2533924�[0m|2532980         (�[1;91m+0.03727%�[0m) [�[1;91m+1.00037x�[0m]
  Total read+write: �[1m      866387559�[0m|866548669       (�[1;92m-0.01859%�[0m) [�[1;92m-1.00019x�[0m]
  Estimated Cycles: �[1m      970155487�[0m|970321941       (�[1;92m-0.01715%�[0m) [�[1;92m-1.00017x�[0m]
"

@github-actions github-actions bot requested a deployment to graphite-dev (Preview) August 14, 2024 11:43 Abandoned
@TrueDoctor TrueDoctor marked this pull request as ready for review August 14, 2024 15:03
@TrueDoctor
Copy link
Member Author

We unfortunetly can't fully test this yet as the ci tries to compare against master, but master does not have the necessary benchmark setup yet. And the ci only shows significant changes so we'll need to actually have changes to test against

@TrueDoctor TrueDoctor enabled auto-merge (squash) August 15, 2024 11:13
@Keavon Keavon disabled auto-merge August 15, 2024 11:14
@Keavon Keavon changed the title Add profile run to ci Add a profiling action to CI which comments on PRs with notable demo art performance variances Aug 15, 2024
@TrueDoctor TrueDoctor merged commit d77857b into master Aug 15, 2024
3 of 4 checks passed
@TrueDoctor TrueDoctor deleted the profile-ci branch August 15, 2024 11:24
TrueDoctor added a commit that referenced this pull request Aug 15, 2024
…art performance variances (#1925)

* Add profile run to ci

* Remove cargo add

* Rename more main to master

* Don't run on master before the pr has been merged

* Fix pr comment step

* Fix comment v2

* Fix v3

* Fix missing features

* Fix string interpolation

* Only post comment on performance diff

* Fix benchmark runner

* Try adding escaping

* Remove escaped quotes

* Use proper master baseline

* Use proper master baseline

* Fix rebase regression

* Remove unused dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants