Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISW - Install Illuminate Step #21638

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

ISW - Install Illuminate Step #21638

wants to merge 9 commits into from

Conversation

laura-b-g
Copy link
Contributor

@laura-b-g laura-b-g commented Feb 13, 2025 •
edited
Loading

Description

closes https://github.com/Graylog2/graylog-plugin-enterprise/issues/9550

Additionally changes:

  • Make wizard navigation non-clickable to ensure a more controlled flow by only using buttons in the steps (as discussed with @tellistone
  • Improve text color in disabled wizard links as they were not readable in the dark theme
    Screenshot 2025-02-14 at 17 02 19
    Screenshot 2025-02-14 at 17 02 08

/nocl
/jpd Graylog2/graylog-plugin-enterprise#9733

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@laura-b-g laura-b-g requested a review from ousmaneo February 13, 2025 14:25
ousmaneo
ousmaneo approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousmaneo ousmaneo ousmaneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laura-b-g @ousmaneo