Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to .NET 9 #198

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Migrate to .NET 9 #198

wants to merge 9 commits into from
+90 −104

Conversation

marco-carvalho
Copy link
Contributor

No description provided.

@github-actions github-actions bot added audio Affects Audio playback during emulation cpu An issue with ARM emulation or the JIT gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. labels Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Download the artifacts for this pull request:

GUI-less
Only for Developers

@WilliamWsyHK
Copy link
Contributor

We should only merge this once .NET 9 has been released globally out of RC, and the version of the global.json is update again to match latest release version.

Meanwhile, we need more people to test and see what has happened, e.g. performance regression/broken game functionality.

@GreemDev
Copy link
Owner

GreemDev commented Nov 7, 2024

We should only merge this once .NET 9 has been released globally out of RC, and the version of the global.json is update again to match latest release version.

Pretty sure that's why this was opened as a draft.

@marco-carvalho
Copy link
Contributor Author

I opened this as a draft precisely because .NET 9 is still in RC; I’ll update the global.json to the latest release version once .NET 9 is officially out. Meanwhile, I’ll encourage additional testing to check for any performance regressions or broken functionality.

@marco-carvalho marco-carvalho marked this pull request as ready for review November 13, 2024 01:42
@bangfire
Copy link

There's some low hanging fruit you could probably add to this PR such as the new Lock object: https://learn.microsoft.com/en-us/dotnet/api/system.threading.lock?view=net-9.0

A quick find replace on object _lock has a a lot of hits that are free to update.

@mattzink
Copy link

mattzink commented Nov 13, 2024 •
edited
Loading

Those warnings about Lock being upcast to object will result in runtime failures. You need to update the method signatures to Lock as well when you pass instances around.

@LukeWarnut
Copy link
Contributor

LGTM. Seems to give a 1% FPS increase on my setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattzink mattzink mattzink left review comments

Assignees
No one assigned
Labels
audio Affects Audio playback during emulation cpu An issue with ARM emulation or the JIT gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marco-carvalho @WilliamWsyHK @GreemDev @bangfire @mattzink @LukeWarnut