Fixed #20 #33
Merged
Fixed #20 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohmn
approved these changes
Jul 25, 2024
|
i havent run these changes on local but they look good to me, once i resolve the baseline migation issue on my local |
dadiorchen
approved these changes
Jul 27, 2024
Comment on lines
+1
to
+12
| import { | ||
| Body, | ||
| Controller, | ||
| Get, | ||
| Post, | ||
| Put, | ||
| ValidationPipe, | ||
| HttpStatus, | ||
| Param, | ||
| Req, | ||
| Res, | ||
| } from '@nestjs/common'; |
There was a problem hiding this comment.
Maybe we should add this: #34
|
|
||
| async function bootstrap() { | ||
| const app = await NestFactory.create(AppModule); | ||
| const port = process.env.PORT || 3006; | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| setupSwagger(app); |
There was a problem hiding this comment.
Very useful for development and coorditation between devs, thank you!
GuningShen
reviewed
Jul 29, 2024
There was a problem hiding this comment.
This file is irrelavant (remove in the future)
GuningShen
approved these changes
Jul 29, 2024
|
🎉 This issue has been resolved in version 1.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Reviewer,
Please provide your .env file with the database url of your postgre instance.
Then:
prisma db pushto apply migrations to the dbyarn prisma:seedto insert the test data to the dbnest start liketo start thelikeapp, since it is the default one, simply runningnest startwill work as well.Please go to /docs to access the swagger ui.
Best,
Shpendi