fix issue with changeLanguage when route parameters are used #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any news on this PR? |
|
Why is this not merged yet? |
|
For all that are waiting for a release you can use: Attached the patch: unpack it and copy to patch folder |
|
Would also love to get this fix. |
|
any updates on when this will be merged? |
|
This bug is still present in v1.0.0-rc.3 and this fix cannot be directly applied. @meeroslav do you plan to fix this issue? It is quite a bug, as any real world application has route parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #151
(copied from issue) Using angular 7+ if a route as parameters, for example :name or :id, this method on this line "...Object.keys(snapshot.params).length ? [snapshot.params] : []," will add to the route the following ";name=valueofthename" or ";id=valueoftheid". There is another problem on the line above on the urlPart this urlPart I think needs to be splited by "/" otherwise if my route is something like "person/:name" the the result of calling the method changeLanguage that calls the traverseSnapshot will result in something like "lang/person%2Fvalueofthename;name=valueofthename".
What is the new behavior?
It will correctly assemble the route when changing the language and using route params.
Does this PR introduce a breaking change?
Other information
This is now an issue for over 3 months and nothing happened. I'm using this fix in production for this time and nothing broke. I think we are save to merge this PR without adding new tests.
Credits to cywolf (https://github.com/cywolf) for the fix!