Add Powderbarrel #1019
Closed
Add Powderbarrel #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LAGIdiot
reviewed
Oct 28, 2022
|
|
||
| import javax.annotation.Nonnull; | ||
|
|
||
| public class BlockPowderBarrel extends VariantBlock<BlockPowderBarrel.BlockType> { |
There was a problem hiding this comment.
Do you need to extend VariantBlock if this has only one variant? Couldn't you just extend Block?
|
|
||
| public BlockPowderBarrel() { | ||
| super(net.minecraft.block.material.Material.TNT); | ||
| setSoundType(SoundType.SAND); |
There was a problem hiding this comment.
This block feels more like wooden, then sandy so it could use wood sounds.
| setFuse(this.getFuse() - 1); | ||
| if (this.getFuse() <= 0) { | ||
| this.setDead(); | ||
| if (!this.world.isRemote && !this.inWater) { |
There was a problem hiding this comment.
Is check for water really needed? Also what is expected behavior from this? As right now entity will just float away and disappear without exploding, which doesn't seems correct.
|
|
||
| } | ||
|
|
||
| protected void explode() { |
There was a problem hiding this comment.
Explosion removes water blocks even water source block which is kind of strange and maybe not intended. Also similarly it will drop TNT bock placed in range instead of priming it.
LAGIdiot
requested changes
Nov 11, 2022
|
Superseded by #2314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I added Powderbarrel, the early game explosive from GT5
It is suggested in #gtceu-todo channel and #275
It has no assembler recipe to encourage people to use regular TNT (same with GT5)
It also can be used in implosion compressor at 2x the input amount as TNT
Powderbarrel can be placed and behaves like TNT but they are different in many places
・It cannot be lit by redstone (GT5 feature)
・It can be lit by breaking it, so you don't have to bring a lighter to your mine (same with GT5)
You can safely harvest it by sneaking or use silk touch
・It's explosion range is 5x5x5 box (bigger than dynamite)
・Most importantly, it drops all items in explosion
Implementation Details:
too much to explain
Please ask me in discord
Outcome:
close #275
Additional info:
8mb.video-7Xp-pl2RFpEm.mp4
Possible compatibility issue:
if any modpack uses TNT to gate Implosion Compressor, it has to ban this block