allow multiple build actions per recipemap #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -197,7 +197,8 @@ public final class RecipeMaps { | |||
| @ZenProperty | |||
| public static final RecipeMap<AssemblyLineRecipeBuilder> ASSEMBLY_LINE_RECIPES = new RecipeMapAssemblyLine<>( | |||
| "assembly_line", new AssemblyLineRecipeBuilder(), AssemblyLineUI::new) | |||
| .onRecipeBuild(AssemblyLineManager::createDefaultResearchRecipe); | |||
| .onRecipeBuild(gregtechId("default_research_recipe"), | |||
There was a problem hiding this comment.
Why does this one use onRecipeBuild instead of onBuild?
There was a problem hiding this comment.
This RecipeMap does not utilize RecipeMapBuilder, and therefore must call RecipeMap#onRecipeBuild instead.
ALongStringOfNumbers
approved these changes
Jan 24, 2024
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows multiple build actions per RecipeMap. This prevents addons having to copy paste the default ones and add to them. Also prevents addons overwriting each other.
Requires build actions to have an associated ResourceLocation to denote them. Also allows removal via this location.
Potential Compatibility Issues
Is not backwards compatible. Build actions now have a required namespace field, which cannot be inferred on our end for backwards-compatibility.