Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ore Dictionary Filter Update #2296

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Conversation

Tictim
Copy link
Contributor

@Tictim Tictim commented Dec 14, 2023

What

This PR is a feature addition for the ore dictionary filter.

Implementation Details

Two options are added to the filter, accessible via UI.

  • Case-sensitivity option is moved from weird flag syntax to toggle button. The function remains the same.
  • Match mode option is added, which has two modes: Match Any, and Match All. This option is used for items with multiple ore dictionary entries - which will make the filter to find any matching entry, or match all entries, when testing the item.

Outcome

16 times the fun factor

Additional Information

Flag syntax was a fucking mistake

Potential Compatibility Issues

A couple of API methods have been deprecated but I'm 69% sure nobody uses it

The old flag syntax provides the same function (makes match case-sensitive when using $c), but now it produces warning about removal of flags in the future.

@Tictim Tictim requested a review from a team as a code owner December 14, 2023 10:42
@Tictim Tictim added the type: feature New feature or request label Dec 14, 2023
@serenibyss
Copy link
Member

Two issues:

  • Case sensitivity option seems to be inverted
    image

  • Both new buttons don't seem to properly save when set, resetting to default values on UI reopen

@serenibyss
Copy link
Member

  • Case sensitivity option seems to be inverted

Nevermind, this one is just a skill issue. The other one seems to be an issue though

@serenibyss serenibyss merged commit d876776 into GregTechCEu:master Dec 18, 2023
4 checks passed
serenibyss pushed a commit that referenced this pull request Dec 18, 2023
MrKono added a commit to GTModpackTeam/GregTech that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants