Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused code & update calc logic #23

Merged
merged 3 commits into from
Jan 26, 2024
Merged

refactor: remove unused code & update calc logic #23

merged 3 commits into from
Jan 26, 2024

Conversation

shuiyisong
Copy link
Contributor

@shuiyisong shuiyisong commented Jan 25, 2024 •
edited
Loading

This pr mainly does:

  1. remove table and region field in all places, including removing macros
  2. use ItemCalculator for unified calculate logic
  3. use MeterRecord to unify WriteRecord and ReadRecord. Now the ItemCalculator does all the calculation, and record only records final value
  4. preserving on_read and on_write for now. Maybe we can unify them later by adding a meter type filed on MeterRecord

fengys1996
fengys1996 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FGTM

@shuiyisong shuiyisong merged commit 80b7271 into main Jan 26, 2024
10 checks passed
@shuiyisong shuiyisong deleted the refactor/remove_unused branch January 26, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengys1996 fengys1996 fengys1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuiyisong @fengys1996