Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fulltext options for column #179

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Jun 24, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

as stated

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Signed-off-by: Zhenchi <[email protected]>
@evenyag
Copy link
Contributor

evenyag commented Jul 8, 2024

Wait until GreptimeTeam/greptimedb#4310 is ready

@evenyag evenyag marked this pull request as draft July 8, 2024 08:59
@zhongzc zhongzc marked this pull request as ready for review July 8, 2024 09:13
@waynexia
Copy link
Member

waynexia commented Jul 8, 2024

Should we use a common structure to avoid duplication?

@zhongzc
Copy link
Contributor Author

zhongzc commented Jul 8, 2024

Should we use a common structure to avoid duplication?

Make sense

Signed-off-by: Zhenchi <[email protected]>
@killme2008 killme2008 merged commit b83f009 into GreptimeTeam:main Jul 8, 2024
6 checks passed
@zhongzc zhongzc deleted the zhongzc/fulltext-options branch July 9, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants