Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mito): Implement mito2 Wal #2103

Merged
merged 5 commits into from
Aug 4, 2023
Merged

feat(mito): Implement mito2 Wal #2103

merged 5 commits into from
Aug 4, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Aug 4, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR implements Wal for mito2 engine.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review August 4, 2023 08:46
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #2103 (8cf8a20) into develop (8bcad93) will decrease coverage by 0.23%.
Report is 3 commits behind head on develop.
The diff coverage is 98.31%.

@@             Coverage Diff             @@
##           develop    #2103      +/-   ##
===========================================
- Coverage    84.90%   84.68%   -0.23%     
===========================================
  Files          686      687       +1     
  Lines       107455   107727     +272     
===========================================
- Hits         91231    91224       -7     
- Misses       16224    16503     +279

@evenyag evenyag requested a review from waynexia August 4, 2023 08:58
waynexia
waynexia reviewed Aug 4, 2023
View reviewed changes
src/mito2/src/wal.rs Outdated Show resolved Hide resolved
@evenyag evenyag requested a review from waynexia August 4, 2023 09:41
fengjiachun
fengjiachun approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Aug 4, 2023
Merged via the queue into GreptimeTeam:develop with commit cb4dd89 Aug 4, 2023
@evenyag evenyag deleted the feat/mito2-wal branch August 4, 2023 11:28
@evenyag evenyag self-assigned this Aug 4, 2023
@evenyag evenyag mentioned this pull request Aug 3, 2023
Closed
40 tasks
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@evenyag @paomian
feat(mito): Implement mito2 Wal (GreptimeTeam#2103)
da1df97 
* feat: define wal struct

* feat: Implement Wal read/write

* feat: obsolete wal

* test: test wal

* refactor: use try_stream and remove async from scan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees

@evenyag evenyag

Labels
None yet
Projects
mito2
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evenyag @fengjiachun @waynexia