Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rfc of refactoring table trait #2106

Merged
merged 1 commit into from
Aug 7, 2023
Merged

docs: rfc of refactoring table trait #2106

merged 1 commit into from
Aug 7, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Aug 4, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

RFC of refactoring the table trait.

rendered

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2065

killme2008
killme2008 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much more clear and better.

@WenyXu
Copy link
Member

WenyXu commented Aug 4, 2023

The scan_to_stream is kind of confused. Why not just the scan. The stream should be the first-class citizen.

@waynexia
Copy link
Member Author

waynexia commented Aug 5, 2023

The scan_to_stream is kind of confused. Why not just the scan. The stream should be the first-class citizen.

There was a scan(), which doesn't return RecordBatchStream but PhysicalPlan instead. The scan_to_stream() is introduced in #1639, there was a time that both methods existed and this is why it has a weird name

fengjiachun
fengjiachun approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evenyag
evenyag approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a try and let the compiler teach us

@evenyag evenyag added this pull request to the merge queue Aug 7, 2023
@waynexia waynexia mentioned this pull request Aug 7, 2023
Closed
8 tasks
Merged via the queue into GreptimeTeam:develop with commit 7210b35 Aug 7, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@waynexia @paomian
docs: rfc of refactoring table trait (GreptimeTeam#2106)
e80ae52 
Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@waynexia @WenyXu @killme2008 @fengjiachun @evenyag