refactor: KeyValues return ValueRef #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynexia
approved these changes
Aug 14, 2023
evenyag
reviewed
Aug 14, 2023
2. Replace OpType/SemanticType with pb's OpType and SemanticType to avoid duplicated conversions.
evenyag
reviewed
Aug 14, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2170 +/- ##
===========================================
- Coverage 85.04% 84.62% -0.43%
===========================================
Files 698 696 -2
Lines 111711 111738 +27
===========================================
- Hits 95008 94557 -451
- Misses 16703 17181 +478 |
evenyag
approved these changes
Aug 14, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: KeyValues return ValueRef * 1. Change KeyValues returned value from pb value to ValueRef 2. Replace OpType/SemanticType with pb's OpType and SemanticType to avoid duplicated conversions. * feat: define min value of OpType as a const * fix: toml format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Returns a
ValueRefinKeyValue'sprimary_key/field/timestampmethod to avoid a clone.Checklist
Refer to a related PR or issue link (optional)