refactor(frontend): TableScan instead of scan_to_stream for COPY TO
#2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
zhongzc
force-pushed
the
zhongzc/refactor-copy-table-to-scan
branch
from
3c1d085 to
00fd0a8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2244 +/- ##
===========================================
- Coverage 85.16% 84.62% -0.54%
===========================================
Files 706 706
Lines 115554 115575 +21
===========================================
- Hits 98412 97806 -606
- Misses 17142 17769 +627 |
zhongzc
requested review from
waynexia and
fengjiachun
and removed request for
waynexia
waynexia
approved these changes
Aug 24, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…O` (GreptimeTeam#2244) * refactor(frontend): TableScan instead of `scan_to_stream` for `COPY TO` Signed-off-by: Zhenchi <[email protected]> * fix: format Signed-off-by: Zhenchi <[email protected]> --------- Signed-off-by: Zhenchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Similar to #2241, replace the invocation of
scan_to_streamwith constructing a TableScan LogicalPlan, and then execute it using the query engine.Checklist
Refer to a related PR or issue link (optional)
#2065