-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track channels with query context and w/rcu #4448
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Please resolve conflicts first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4448 +/- ##
==========================================
- Coverage 84.87% 84.60% -0.27%
==========================================
Files 1081 1081
Lines 193011 193147 +136
==========================================
- Hits 163809 163405 -404
- Misses 29202 29742 +540 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This patch adds a new field
channel
in query context so the execution path now knows which source the query comes from. It also add this channel to meter, by which we can add statistics for w/rcus of each channel.Upstream changes that has to be merged before this:
Note that this patch changes QueryContext extension type in axum, from
QueryContextRef
to plainQueryContext
so that we can modify it in http handlers, to setchannel
field based on different handler.Checklist