-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: opensrv Use After Free update #4732
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4732 +/- ##
==========================================
- Coverage 84.79% 84.63% -0.16%
==========================================
Files 1115 1117 +2
Lines 201200 201340 +140
==========================================
- Hits 170598 170402 -196
- Misses 30602 30938 +336 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4696
What's changed and what's your intention?
opensrv
to fix a uaf in it's code(test write large sql using mysql protocol on my local machine can now work without panic), also update a few other crates due to version skew.CryptoProvider
usingring
in every related tests and in main fn of greptime binaryaws-lc-rs
useprebuilt-nasm
on windows to prevent need to install nasm assembler on windows for compilePossible change to unrelated part of code
A concern is that after update
rustls
from0.22
to0.23
it now useaws-lc
as default crypto lib, but it require nasm assembler on windows.so for now I just use
rustls = { version = "0.23", default-features = false, features = ["ring", "logging", "std", "tls12"] }
for the old ring libthis behavior might need to change in the future. (Now both features are activate due to depend like opensrv enabled
aws-lc-rs
feature ofrustls
and cargo unify both features and enabled them both)Edited:
now some tests related toFixed by providingtls
seems to failing tooCryptoProvider
usingring
in every related tests** and call install ring provider ingreptime-bin
's main fnSee more in sunng87/pgwire@a673412 and
https://docs.rs/rustls/latest/rustls/crypto/struct.CryptoProvider.html#using-the-per-process-default-cryptoprovider
Checklist
currently it just depend on my own forkNow merged