-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the new option --memory-meta-storage #200
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #200 +/- ##
===========================================
- Coverage 41.01% 40.84% -0.17%
===========================================
Files 16 16
Lines 990 994 +4
===========================================
Hits 406 406
- Misses 479 483 +4
Partials 105 105 ☔ View full report in Codecov by Sentry. |
related issue: #174 |
@confoc The e2e tests are failed. You should fix it. |
@confoc I'm confused with the PR. I can't see something about the new option of |
@confoc Change CreateTableSQL to following can fixed the e2e failling:
|
Can add baremetal e2e test in next PR ? |
Why close the PR ? |
I don't know how.Maybe I make some wrong operations.I don't remember, sry |
I have already add baremetal e2e test in the PR |
Seem ready review ? @confoc |
chore: remove opentsdb addr (GreptimeTeam#203)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the PR are good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the PR are good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bootstrap the whole cluster without installing etcd for testing purposes through using the memory storage of metasrv in bare-metal mode.