Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add baremetal cluster e2e test #206

Closed
wants to merge 110 commits into from
Closed

Conversation

confoc
Copy link
Contributor

@confoc confoc commented Jun 13, 2024

Add new baremetal database CRUD

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (ad6cf8d) to head (3ab89fb).
Report is 1 commits behind head on develop.

Files Patch % Lines
pkg/cluster/baremetal/create.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #206   +/-   ##
========================================
  Coverage    40.84%   40.84%           
========================================
  Files           16       16           
  Lines          994      994           
========================================
  Hits           406      406           
  Misses         483      483           
  Partials       105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}()

go func() {
time.Sleep(100 * time.Second)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: It is not recommended to use the sleep. You can modify it to periodically detect whether the port is connected and set a timeout.

@daviderli614
Copy link
Member

suggestion:The k8s mode and baremetal mode should be located in different places for testing, not in the same place.

@daviderli614
Copy link
Member

This action has following errors, but the test passes?

component 'frontend.0' binary '/home/runner/.gtctl/artifacts/binaries/greptime/v0.8.2/bin/greptime' (pid '17288') exited with error: exit status 1
args: '[--log-level=info frontend start --metasrv-addr=0.0.0.0:3002 --http-addr=0.0.0.0:4000 --rpc-addr=0.0.0.0:4001 --mysql-addr=0.0.0.0:4002 --postgres-addr=0.0.0.0:4003]'

@zyy17
Copy link
Collaborator

zyy17 commented Jul 18, 2024

@confoc Are you still working on it?

@zyy17
Copy link
Collaborator

zyy17 commented Aug 19, 2024

@confoc Close the PR for inactive development. If you want to continue it in the future, you can re-open the PR or create a new PR.

@zyy17 zyy17 closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants