-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add baremetal cluster e2e test #206
Conversation
chore: remove opentsdb addr (GreptimeTeam#203)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #206 +/- ##
========================================
Coverage 40.84% 40.84%
========================================
Files 16 16
Lines 994 994
========================================
Hits 406 406
Misses 483 483
Partials 105 105 ☔ View full report in Codecov by Sentry. |
tests/e2e/greptimedbcluster_test.go
Outdated
}() | ||
|
||
go func() { | ||
time.Sleep(100 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: It is not recommended to use the sleep. You can modify it to periodically detect whether the port is connected and set a timeout.
suggestion:The k8s mode and baremetal mode should be located in different places for testing, not in the same place. |
This action has following errors, but the test passes?
|
@confoc Are you still working on it? |
@confoc Close the PR for inactive development. If you want to continue it in the future, you can re-open the PR or create a new PR. |
Add new baremetal database CRUD