-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to version 1.10.0 #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More than two
Allow more than 2 busbars per substation
Remove comparisons with float
Code cleaning
Improve docs
Mdp doc (init) and finish tests on more than 2 busbar per substation
Improve MDP doc + upgrade to 1.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env.action_space.get_all_unitary_line_set
andenv.action_space.get_all_unitary_topologies_set
might have changed (this is causedby a rewriting of these functions in case there is not 2 busbars per substation)
l2rpn_utils
module did not stored correctly the orderof actions and observation for wcci_2020
act.get_gen_modif
(vector of wrong size was used, could leadto some crashes if
n_gen >= n_load
)act.as_dict
when shunts were modifiedvalues for certain values of p or q (an AmbiguousAction exception was raised wrongly)
_BackendAction
: the "last known topoolgy" was not properly computedin some cases (especially at the time where a line was reconnected)
MultiDiscreteActSpace
andDiscreteActSpace
could be the same classeson some cases (typo in the code).
MultiDiscreteActSpace
: the "do nothing" action could not be done ifone_sub_set
(orone_sub_change
)was selected in
attr_to_keep
gridobj.topo_vect_element()
that does the opposite ofgridobj.xxx_pos_topo_vect
gridobj.get_powerline_id(sub_id)
that gives theid of all powerlines connected to a given substation
obs.get_back_to_ref_state(...)
for the observation and not only the action_space.
(by calling the relevant things done in the base class
in
BaseAction
andBaseObservation
) and by using thefrom packaging import version
to check version (instead of comparing strings)
check_kirchoff
to make it slightly clearerAction
moduleObservation
modulegridobj.get_lines_id
,gridobj.get_generators_id
,gridobj.get_loads_id
gridobj.get_storages_id
are now class methods and can be used withtype(env).get_lines_id(...)
or
act.get_lines_id(...)
for example.obs.get_energy_graph()
by giving the "local_bus_id" and the "global_bus_id"of the bus that represents each node of this graph.
obs.get_elements_graph()
by giving access to the bus id (local, global andid of the node) where each element is connected.
gym_compat
module (more work still required in this area)MultiDiscreteActSpace
to have one "dimension" controling all powerlines(see "one_line_set" and "one_line_change")