Update for pandapower v3.0 #99
Open
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2024 15:40
Signed-off-by: AzureAD\PanagiotisXenos <[email protected]>
Signed-off-by: AzureAD\PanagiotisXenos <[email protected]>
panos-xenos
force-pushed
the
update_pandapower_v3
branch
from
51b75ff to
94f5e16
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @BDonnot, we are updating pandapower to v3.0 in which we are renaming/re-purposing the tap_phase_shifter parameter to tap_changer_type. We picked up an error when running our tests which is linked to your _aux_add_trafo.py lib. We propose a simple change in the code that works with both old and new implementation. We hope it's correct to merge in the master branch. Please let us know if you have any comments or suggestions.