Bump atlas to 0.39.0 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
commented
Oct 25, 2024
| COMMAND ${CMAKE_COMMAND} -E copy $<TARGET_FILE:${ct_tgt}> ${CMAKE_LIBRARY_OUTPUT_DIRECTORY} | ||
| DEPENDS ${ct_tgt} | ||
| ) | ||
| if(NOT TARGET copy_${ct_tgt}) |
There was a problem hiding this comment.
This change just allows calling copy_target multiple times with the same argument.
tehrengruber
commented
Oct 25, 2024
| if(dep MATCHES "eckit.*") | ||
| copy_target(${dep}) | ||
| endif() | ||
| foreach(lib "atlas" "atlas_io") |
There was a problem hiding this comment.
We need to copy not only the atlas, but also atlas_io targets. Since they share dependencies, I adopted copy_target to be callable multiple times with the same argument. Without this change eckit_codec is missing and loading the package fails.
|
Since the PR changes affect only CMake, I think @havogt is a better fit to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.