Skip to content

Commit

Permalink
fix[cartesian]: Deactivate K offset write in gt:gpu (#1755)
Browse files Browse the repository at this point in the history
Following the issue logged as
#1754 we are deactivating the
K-offset write feature until we can figure out why it's failing.

I will monitor any activity on the ticket if users are hit by this.

---------

Co-authored-by: Hannes Vogt <[email protected]>
  • Loading branch information
FlorianDeconinck and havogt authored Nov 28, 2024
1 parent f6c0498 commit 3ece412
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/gt4py/cartesian/frontend/gtscript_frontend.py
Original file line number Diff line number Diff line change
Expand Up @@ -1460,6 +1460,13 @@ def visit_Assign(self, node: ast.Assign) -> list:
loc=nodes.Location.from_ast_node(t),
)

if self.backend_name in ["gt:gpu"]:
raise GTScriptSyntaxError(
message=f"Assignment to non-zero offsets in K is not available in {self.backend_name} as an unsolved bug remains."
"Please refer to https://github.com/GridTools/gt4py/issues/1754.",
loc=nodes.Location.from_ast_node(t),
)

if not self._is_known(name):
if name in self.temp_decls:
field_decl = self.temp_decls[name]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,10 @@ def test_K_offset_write_conditional(backend):
pytest.skip(
f"{backend} backend with CUDA 11 and/or GCC 10.3 is not capable of K offset write, update CUDA/GCC if possible"
)
if backend in ["gt:gpu"]:
pytest.skip(
f"{backend} backend is not capable of K offset write, bug remains unsolved: https://github.com/GridTools/gt4py/issues/1754"
)

arraylib = get_array_library(backend)
array_shape = (1, 1, 4)
Expand Down

0 comments on commit 3ece412

Please sign in to comment.