Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
address review comment
Browse files Browse the repository at this point in the history
havogt committed Jan 29, 2024
1 parent 470a36e commit b0bf88f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/gt4py/next/common.py
Original file line number Diff line number Diff line change
@@ -843,6 +843,8 @@ def is_connectivity_field(
return isinstance(v, ConnectivityField) # type: ignore[misc] # we use extended_runtime_checkable


# Utility function to construct a `Field` from different buffer representations.
# Consider removing this function and using `Field` constructor directly. See also `_connectivity`.
@functools.singledispatch
def _field(
definition: Any,
@@ -851,11 +853,10 @@ def _field(
domain: Optional[DomainLike] = None,
dtype: Optional[core_defs.DType] = None,
) -> Field:
# Utility function to construct a `Field` from different buffer representations.
# Consider removing this function and using `Field` constructor directly.
raise NotImplementedError


# See comment for `_field`.
@functools.singledispatch
def _connectivity(
definition: Any,

0 comments on commit b0bf88f

Please sign in to comment.