Skip to content

Commit

Permalink
Address reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tehrengruber committed Mar 20, 2024
1 parent d4648c9 commit d920c88
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/gt4py/next/iterator/transforms/inline_lifts.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,12 @@ def _transform_and_extract_lift_args(
trace_shifts.copy_recorded_shifts(from_=arg, to=new_arg, required=False)
new_args.append(new_arg)

# todo: test this properly. not really sure about it...
# TODO(tehrengruber): This is not tested properly. There are too many combinations of this
# that need to be tested, so we should write some infrastructure that automatically
# generates various combinations and checks that the recorded shifts that are returned
# as a result of this pass match what the TraceShifts pass gives. Note that it is in any
# case required to do the update here since we need the updated recorded shifts in the
# pass itself.
if recorded_shifts_base is not None:
if isinstance(inner_stencil, ir.Lambda):
recorded_shifts = inner_stencil.params[i].annex.recorded_shifts
Expand Down Expand Up @@ -401,6 +406,6 @@ def visit_FunCall(self, node: ir.FunCall, **kwargs) -> ir.Node:
transformed_node = method(new_node, **kwargs)
# if the transformation returned `None` it did not apply and we continue.
if transformed_node is not None:
return transformed_node
new_node = transformed_node

return new_node

0 comments on commit d920c88

Please sign in to comment.