feat[next]: DaCe support for tuple returns #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4000005.
edopao
commented
Oct 18, 2023
src/gt4py/next/program_processors/runners/dace_iterator/utility.py
Outdated
Show resolved
Hide resolved
This reverts commit e1ab5c5.
petiaccja
suggested changes
Oct 19, 2023
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_sdfg.py
Outdated
Show resolved
Hide resolved
petiaccja
reviewed
Oct 19, 2023
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds partial support for stencils with tuple returns. The motivation is that tuple returns are used in icon4py stencils, although the internal expressions do not operate on tuples. Tuples are just a mean to aggregate multiple-outputs from one stencil. This is why this PR does not contain support for scan or conditional expressions with tuples.