Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next]: DaCe support for field arguments with domain offset #1348

Merged
merged 11 commits into from
Oct 16, 2023

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Oct 10, 2023

Description

Adding support in DaCe backend for field arguments with domain offset. This feature is required by following icon4py stencils:

N.B. The solution has been updated to be consistent with the alphabetical order of dimensions in the field domain (see discussion in #1346).

edopao added 2 commits October 6, 2023 10:58
Required by following icon4py stencils:
- TestMoVelocityAdvectionStencil03
- TestMoVelocityAdvectionStencil02VnIe
@edopao edopao requested a review from petiaccja October 10, 2023 16:23
@edopao edopao marked this pull request as ready for review October 10, 2023 16:23
@edopao
Copy link
Contributor Author

edopao commented Oct 11, 2023

This PR depends on #1346, it contains indeed all changes from #1346. Therefore, #1346 should be merged first, then this one rebased.

@edopao edopao force-pushed the dace-field_offset branch from 23f4d5f to 405dad6 Compare October 11, 2023 13:20
Copy link
Contributor

@petiaccja petiaccja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for #1346 to be merged into main and then review the code itself. Otherwise, the concept of the PR is good.

@edopao edopao requested a review from petiaccja October 13, 2023 14:49
@edopao
Copy link
Contributor Author

edopao commented Oct 16, 2023

The solution has been updated to be consistent with the alphabetical order of dimensions in the field domain (see discussion in #1346).

@edopao edopao merged commit 45a6e6d into GridTools:main Oct 16, 2023
18 checks passed
@edopao edopao deleted the dace-field_offset branch October 16, 2023 09:55
@edopao edopao changed the title feat[next-dace]: support for field arguments with domain offset feat[next]: DaCe support for field arguments with domain offset Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants