-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[next]: DaCe support for field arguments with domain offset #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required by following icon4py stencils: - TestMoVelocityAdvectionStencil03 - TestMoVelocityAdvectionStencil02VnIe
edopao
force-pushed
the
dace-field_offset
branch
from
October 11, 2023 13:20
23f4d5f
to
405dad6
Compare
petiaccja
suggested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for #1346 to be merged into main and then review the code itself. Otherwise, the concept of the PR is good.
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_sdfg.py
Outdated
Show resolved
Hide resolved
The solution has been updated to be consistent with the alphabetical order of dimensions in the field domain (see discussion in #1346). |
petiaccja
approved these changes
Oct 16, 2023
edopao
changed the title
feat[next-dace]: support for field arguments with domain offset
feat[next]: DaCe support for field arguments with domain offset
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support in DaCe backend for field arguments with domain offset. This feature is required by following icon4py stencils:
N.B. The solution has been updated to be consistent with the alphabetical order of dimensions in the field domain (see discussion in #1346).