feat[next]: Limit use of global type inference in CollapseTuple pass #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is used to get the tuple size or the simple heuristics can be configured using a boolean flag to the pass Execute with ITIR type inference once in loop in pass manager and in all subsequent runs use the simple heuristics
nfarabullini
force-pushed
the
revert_tuple_get_edits
branch
from
0af8960 to
555a40d
Compare
nfarabullini
changed the title
tehrengruber
requested changes
Nov 5, 2023
tehrengruber
changed the title
Co-authored-by: Till Ehrengruber <[email protected]>
Co-authored-by: Till Ehrengruber <[email protected]>
Co-authored-by: Till Ehrengruber <[email protected]>
Co-authored-by: Till Ehrengruber <[email protected]>
Co-authored-by: Till Ehrengruber <[email protected]>
Co-authored-by: Till Ehrengruber <[email protected]>
tehrengruber
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
CollapseTuplepass configurable such that whether the global ITIR type inference is used to get the tuple size or the simple local inference can be configured using a boolean flag.Execute with global ITIR type inference once in loop in pass manager and in all subsequent runs use the local inference. This significantly improves the performance of the toolchain.