feat[next][dace]: Add more debug info to DaCe

[kotsaloscv]

Description

Add more debug info to DaCe (pass SourceLocation from past/foast to itir, and from itir to the SDFG)

[petiaccja]

The PR is pretty straightforward (that's a good thing), I left a few comments, but other than that I think there isn't much to change.

However, one thing I'm really missing is tests or any way to ensure that location info is properly transmitted. For example, if someone writes a new iterator IR pass and they don't pass the location, we won't know until somebody tries to look at the generated SDFGs while doing something else. That may be weeks or months down the line and finding the culprit causing the loss of location info will be difficult and annoying.

If you make the location field mandatory in iterator IR, that would do the trick. You could also enforce that location is not None in the SDFG generation, though that's less clear. You could also add a test that verifies if the SDFG has debug info.

[kotsaloscv]

The PR is pretty straightforward (that's a good thing), I left a few comments, but other than that I think there isn't much to change.

However, one thing I'm really missing is tests or any way to ensure that location info is properly transmitted. For example, if someone writes a new iterator IR pass and they don't pass the location, we won't know until somebody tries to look at the generated SDFGs while doing something else. That may be weeks or months down the line and finding the culprit causing the loss of location info will be difficult and annoying.

If you make the location field mandatory in iterator IR, that would do the trick. You could also enforce that location is not None in the SDFG generation, though that's less clear. You could also add a test that verifies if the SDFG has debug info.

FYI, I have integrated Peter's comments in my PR.
I also experimented on making the SourceLocation a mandatory field in the itir node, but it turns out that we will have to modify the code in countless places. There are so many tests that experiment with itir nodes for which we will have to pass a valid location. I do not think that it worths the investment. As is right now, I find it less intrusive and it is up to us to decide what we want to pass from past/foast to itir.
Regarding the testing of the genereted sdfgs to have a valid bebuginfo field, I have added this check in the code:
https://github.com/kotsaloscv/gt4py/blob/more_debinfo/src/gt4py/next/program_processors/runners/dace_iterator/__init__.py#L222
At least, the developer will always be warned about this field and add it appropriately.

Some tests are failing because they need this modification from DaCe's side: spcl/dace#1469

cc: @havogt @tehrengruber

[kotsaloscv]

FYI, all the comments have been integrated in the PR and now all the tests are passing.
cc: @tehrengruber @havogt

[tehrengruber]

Changes as discussed in person.

already resolved after discussions