feature[next]: Inline center deref lift vars #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
reviewed
Mar 5, 2024
| @@ -125,7 +125,8 @@ def new_name(name): | |||
| class InlineLambdas(PreserveLocationVisitor, NodeTranslator): | |||
| """Inline lambda calls by substituting every argument by its value.""" | |||
|
|
|||
| PRESERVED_ANNEX_ATTRS = ("type",) | |||
| # TODO: document that these annex attrs are preserved, but not used by the pass itself. | |||
…enter_deref_lift_vars
…enter_deref_lift_vars
…enter_deref_lift_vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline all variables which are derefed in the center only (i.e. unshifted).
Consider the following example where
varis never shifted:let(var, (↑stencil)(it))(·var + ·var)Directly inlining
varwould increase the size of the tree and duplicate the calculation.Instead, this pass computes the value at the current location once and replaces all previous
references to
varby an applied lift which captures this value.let(_icdlv_1, stencil(it))(·(↑(λ() → _icdlv_1) + ·(↑(λ() → _icdlv_1))The lift inliner can then later easily transform this into a nice expression:
let(_icdlv_1, stencil(it))(_icdlv_1 + _icdlv_1)