Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update requirements and change ruff-format style to stable #1517

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

egparedes
Copy link
Contributor

@egparedes egparedes commented Apr 2, 2024

Bump requirements' versions, update ruff format style and apply changes.

To reproduce code style changes locally, bump ruff version (either run tox run -e requirements-base, which requires python3.8 or update ruff pre-commit hook in .pre-commit-config.yaml to v0.3.5), remove preview = true setting in the ruff configuration (in pyproject.toml, inside the [[tool.ruff.format]] table) and run ruff-format.

In a following PR (#1518) the format will be changed to reduce vertical space usage.

@egparedes egparedes requested review from havogt and tehrengruber April 2, 2024 14:25
@egparedes egparedes force-pushed the update-ruff-format-style branch from 6725994 to 1f47f1a Compare April 2, 2024 14:37
@egparedes egparedes marked this pull request as draft April 2, 2024 14:41
@egparedes egparedes force-pushed the update-ruff-format-style branch from 1f47f1a to dec7b61 Compare April 2, 2024 14:49
@egparedes egparedes force-pushed the update-ruff-format-style branch from dec7b61 to 0ef0c5c Compare April 2, 2024 15:38
@egparedes egparedes marked this pull request as ready for review April 2, 2024 15:40
@egparedes egparedes changed the title style: Update ruff format style style: update ruff format style Apr 2, 2024
@egparedes egparedes changed the title style: update ruff format style style: update requirements and change ruff-format style to stable Apr 2, 2024
@egparedes egparedes requested a review from havogt April 2, 2024 16:05
@egparedes egparedes requested a review from tehrengruber April 2, 2024 16:11
@egparedes egparedes merged commit fb37a58 into GridTools:main Apr 3, 2024
55 checks passed
egparedes added a commit that referenced this pull request Apr 3, 2024
Reformat with ruff-format to remove unnecessary line splitting due to
automatically inserted trailing commas.
To reproduce locally, add the `skip-magic-trailing-comma = true` setting
in the ruff configuration (in `pyproject.toml`, inside the
`[[tool.ruff.format]]` table), run ruff-format, then remove the setting
and run it again.

This PR is a continuation of  #1517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants