feat[next][dace]: Parallel Map Fusion #1620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I now use reapeated, because the two transformations could themsleves introduces trivial maps.
It violates the standard, but in file listing it is more logical to use that name, especially if we add the parallel fusion.
There is no test for that yet.
It could be more but let's life with that.
On the top level it is probably always good. However, inside it might not be that good, there we need more fine grade controle.
|
@philip-paul-mueller @edopao Does this PR contain any useful code which hasn't been yet merged in main? Otherwise, could you close it to reduce noise in the repo? |
|
This PR is superseded by PR#1639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the DaCe transformation to fuse Maps that are parallel.
The
SerialMapFusiontransformation is only able to handle Maps that are serial.This PR can only be merged after PR#1594 has been merged.