feat[next]: Enable GTIR dace backend in feature tests #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/gt4py/next/program_processors/runners/dace_fieldview/workflow.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/workflow.py
Outdated
Show resolved
Hide resolved
edopao
changed the title
edopao
changed the title
havogt
approved these changes
Nov 5, 2024
| if sym.name not in shape_args: | ||
| shape_args[sym.name] = size | ||
| elif shape_args[sym.name] != size: | ||
| # TODO(edopao): This case is only hit if all fields in a tuple have the same dims and sizes. |
There was a problem hiding this comment.
I am confused by the comment. Can you explain?
There was a problem hiding this comment.
You are right, I can write it better:
The same shape symbol is used by all fields of a tuple, because the current assumption is that all fields in a tuple have the same dims and sizes. Therefore, this if-branch only exists to ensure that the array size (i.e. the value assigned to the shape symbol) is the same for all fields in a tuple.
TODO(edopao): change toassert sym.name not in shape_argsto ensure that shape symbols are unique, once the assumption on tuples is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent of #1702, but for dace backend. These code changes are tested on the GTIR integration branch.
Note that SDFG auto-optimization is disabled by default, in both the CPU and GPU DaCe backends.
We have to keep the GPU backend disabled in GT4Py feature tests because there are errors related to symbolic domain and sub-domain computation in following tests:
test_domain_input_bounds_1, test_domain_tupletest_where_k_offsettest_ffront_lap, test_ffront_skewedlap, test_ffront_laplapThese errors are solved by next DaCe release (v1.0.0). The GPU tests can be enabled once PR #1639 is merged.