test[cartesian]: Unskip blocked DaCe tests after DaCe upgrade #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Florian, current versions of DaCe should be able to handle these cases.
romanc
force-pushed
the
romanc/unskip-dace-tests
branch
from
3fb6ab8 to
f39d283
Compare
romanc
changed the title
|
@egparedes can you run CSCS-CI for us? Thanks! |
|
@twicki please review |
|
cscs-ci run |
havogt
approved these changes
Nov 1, 2024
twicki
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of tests were skipped in the DaCe backend with issue #1084 because they were throwing compiler errors. Current versions of DaCe can handle these cases again. Re-enabling the test cases. CI confirms (so far) that there aren't any issues anymore.
/cc @FlorianDeconinck as discussed.
Requirements