Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix name of license file configured in pyproject.toml #1718

Merged

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Oct 29, 2024

Description

The license file configured in pyproject.toml was missing the *.txt extension, leading to warnings in tests.

Parent: GEOS-ESM/SMT-Nebulae#89

Requirements

  • All fixes and/or new features come with corresponding tests.
    Tested locally and the warning is now gone. CI still runs as before.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.
    N/A

The license file configured in `pyproject.toml` was missing the `*.txt`
extension, leading to warnings in tests.
@romanc romanc marked this pull request as ready for review October 29, 2024 15:03
@romanc
Copy link
Contributor Author

romanc commented Oct 29, 2024

@FlorianDeconinck / @twicki as discussed

@egparedes can you also have a look at this one? Sorry for the load of small PRs. I'll go back to my main task now and be buried in the debugger for a day or two ... haha ... 😄

Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egparedes egparedes merged commit c78bafd into GridTools:main Oct 29, 2024
30 checks passed
@romanc romanc deleted the romanc/fix-configured-lincense-file branch October 29, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants